Re: [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

----- Original Message -----
> On Tue, 2017-07-18 at 16:50 +0200, Christophe de Dinechin wrote:
> > > On 18 Jul 2017, at 16:48, Christophe Fergeau <cfergeau@xxxxxxxxxx>
> > > wrote:
> > > 
> > > Hey,
> > > 
> > > On Tue, Jul 18, 2017 at 04:37:29PM +0200, Christophe de Dinechin
> > > wrote:
> > > > OK. Since you seem to feel more strongly about this than me, I
> > > > changed it.
> > > > Pushed to freedesktop.org. Since this is the first time I push
> > > > myself to this repo,
> > > > would you please be kind enough to check that what I pushed looks
> > > > sane?
> > > 
> > > This looks all good, only minor comment I have is with the 'spice-
> > > gtk'
> > > prefix, you prepended it to the commit log, so it appears in git
> > > log, we
> > > usually use nothing, or a more specific prefix.
> > 
> > OK. For my education, what would you suggest as being an acceptable
> > more specific prefix be in that case, if any?
> > 
> > > The messages to the mailing list are prefixed with "spice-gtk", but
> > > through git send-email --subject-prefix spice-gtk.
> 
> By the way, this can also be achieved on a per-repository basis by
> setting the format.subjectPrefix config option. Or, in ./.git/config:
> 
> [format]
> 	subjectprefix = spice-gtk
> 

That and git-publish (we have a .gitpublish in spice-gtk tree), which I'd recommend for sending series.
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]