> > On Fri, Jul 14, 2017 at 05:48:45AM -0400, Frediano Ziglio wrote: > > > > > > If one does not have gdb installed it's nicer > > > to simply get the error message (and some > > > debug messages). > > > > > > > I don't really agree. The imagetest is supposed to be a test > > utility so is used only during development. > > The fact that you added support for running it at package build time > means it's used for a little bit more than "development" :) > This was changed, now is build and used only during "make check" and not installed on the system on "make install" > I'd at least pick the first hunk of this patch which returns a proper > error/help string when not enough args are passed, rather than just > asserting (one might want to run this by hand when a test failure is > detected). I'm fine with the rest of the code using asserts. > > Christophe > Yes, for kind of "usage" help would be good. Would be good to have a kind of errx(3) function/macro Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel