Re: [PATCH server] tests: Initialize all members of SpiceBaseInterface struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/23/2017 10:58 AM, Frediano Ziglio wrote:
> 
> <snip/>
> 
> You can update and post again or I can change before pushing it.
> 
> What about, simply:
> ******
> When compiling, -Werror=missing-field-initializers is enabled.
> However, some gcc versions (like Gentoo 4.9.4 one) fail to see
> that all the members of the SpiceBaseInterface struct are
> initialized:
> 
> test-display-base.c:844:5: error: missing initializer for field
> 'description' of 'SpiceBaseInterface'
> [-Werror=missing-field-initializers] .base.description   = "test
> spice virtual channel char device",
> 
> The solution is to initialize .base member as a structure at once
> instead of multiple times per each member.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ******
> 

Yup, this works for me too. Can you update it before pushing? It's a
small nit after all ;-)

Thanks,

Michal
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]