Re: [PATCH spice-html5 1/4] spiceconn: Add function to test channel capabilities

[Uri Lublin <uril@xxxxxxxxxx>]

On 06/08/2017 05:27 PM, Pavel Grunt wrote:
> From: Tomáš Bohdálek <tom.bohdalek@xxxxxxxxx>
>
> This will be used in other commits.
> ---
>   spiceconn.js | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
>
> diff --git a/spiceconn.js b/spiceconn.js
> index 33e7388..d76f8e2 100644
> --- a/spiceconn.js
> +++ b/spiceconn.js
> @@ -243,6 +243,9 @@ SpiceConn.prototype =
>           else if (this.state == "link")
>           {
>               this.reply_link = new SpiceLinkReply(mb);
> +            this.common_caps = this.reply_link.common_caps;
> +            this.channel_caps = this.reply_link.channel_caps;
> +
>                // FIXME - Screen the caps - require minihdr at least, right?
>               if (this.reply_link.error)
>               {
> @@ -495,6 +498,22 @@ SpiceConn.prototype =
>           var e = new Error("Connection timed out.");
>           this.report_error(e);
>       },
> +
> +    test_capability: function(caps, cap)
> +    {
> +        var ret = (caps >> cap).toString(2) & 1;

Hi Pavel,

Do you need to convert it to string ?
Why not simply  (caps >> cap) & 1;

Uri.

> +        return ret;
> +    },
> +
> +    channel_test_capability: function(cap)
> +    {
> +        return this.test_capability(this.channel_caps, cap);
> +    },
> +
> +    channel_test_common_capability: function(cap)
> +    {
> +        return this.test_capability(this.common_caps, cap);
> +    }
>   }
>   
>   function spiceconn_timeout(sc)

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel