On 06/21/2017 01:13 PM, Frediano Ziglio wrote:
----- Original Message -----
From: "Uri Lublin" <uril@xxxxxxxxxx>
To: "Frediano Ziglio" <fziglio@xxxxxxxxxx>, spice-devel@xxxxxxxxxxxxxxxxxxxxx
Sent: Tuesday, June 20, 2017 6:39:44 PM
Subject: Re: [PATCH spice-common] canvas-base: Do not attempt useless cast on stride adjustment
On 06/20/2017 04:52 PM, Frediano Ziglio wrote:
memmove already deal with any alignment so there's no
reason to have row byte pointer cast to uint32_t.
Hi Frediano,
I think the code has no problem with memmove itself, but
with the pointer used later being not-aligned (but only for
non-x86 arch ?).
Specifically this reverts part of commit
858a0bfae9925ea6e363573de4113090c7821133
so I think a longer commit log is needed.
I suggested the change time ago like in
https://lists.freedesktop.org/archives/spice-devel/2017-May/037670.html.
I don't understand how I should extend the comment.
You are both right.
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel