On 06/19/2017 01:28 PM, Frediano Ziglio wrote:
On 06/19/2017 09:40 AM, Pavel Grunt wrote:
Hi,
On Sun, 2017-06-18 at 05:06 -0400, Frediano Ziglio wrote:
ping
no reply to Uri's questions?
Specifically, it's not clear why not ignore all .html files.
Because html files are common and you want to ignore only
autogenerated one.
That's theoretical. Practically, there are no such html files in
spice-server.
I do not mind that much about the patch itself, but it would be
nice if you change the log message to say that you only want to
block generated files.
----- Original Message -----
From: "Uri Lublin" <uril@xxxxxxxxxx>
To: "Frediano Ziglio" <fziglio@xxxxxxxxxx>, spice-devel@xxxxxxxxxx
desktop.org
Sent: Thursday, January 26, 2017 1:22:39 PM
Subject: Re: [PATCH spice-server v2] gitignore:
Reduce html files exclusion
On 01/26/2017 12:52 PM, Frediano Ziglio wrote:
ping
Limit the html files ignored.
Can happen that you are working on some html files on your
main
spice-server directory and it's not desirable to ignore them.
Hi Frediano,
How can that happen ? What html files one may work on ?
I'd add in the commit log that html files under docs/ are still
ignored (be more specific with above "Limit").
Uri.
Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
---
.gitignore | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Changes since v1:
- remove redundant ignore;
- move exclusion to get better order.
diff --git a/.gitignore b/.gitignore
index cac10f9..85f922b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,7 +4,6 @@
*.tar.bz2
*.tar.gz
*.pyc
-*.html
aclocal.m4
autom4te.cache
compile
@@ -34,7 +33,7 @@ INSTALL
.version
.tarball-version
docs/manual/manual.chunked/
-docs/manual/manual.html
+docs/**/*.html
.dirstamp
.deps
.libs
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel