Re: [PATCH spice-server 00/22] reds: Use bool for boolean types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Fri, Jun 16, 2017 at 10:13:12AM +0100, Frediano Ziglio wrote:
> > Different fields used "int" instead of a proper boolean type.
> > Switch to "bool" type and related mnemonics.
> > Some changesets should probable be squashed together (for instance
> > I would merge some migration field in RedsState) but is easier to
> > review.
> > "bool" is a bit smaller than "int"/"gboolean" so the structures
> > can be rearranges to use less bytes but I don't consider this
> > really important and is more suitable for a future optimization.
> 
> Series looks good overall, going to cause some rebase pain though.. ;)
> 
> Christophe
> 

Send a version 2 for 22/22 (SpiceMouseMode).

Should I consider acked?
Should I merge some of them?

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]