On Tue, Jun 13, 2017 at 07:08:34PM +0200, Christophe Fergeau wrote: > This is causing issues with potential improvements to the logging > system, and I've always found this usage a bit odd anyway. > This means we also need to remove -Wformat-zero-length from our CFLAGS > to avoid warnings from the compiler. > > Signed-off-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> > --- > m4/manywarnings.m4 | 1 - > server/char-device.c | 2 +- > server/dcc.c | 4 ++-- > server/display-channel.c | 6 +++--- > server/main-channel.c | 2 +- > server/mjpeg-encoder.c | 2 +- > server/red-channel-client.c | 4 ++-- > server/red-worker.c | 4 ++-- > server/reds.c | 28 ++++++++++++++-------------- > server/stream.c | 2 +- > 10 files changed, 27 insertions(+), 28 deletions(-) > > diff --git a/m4/manywarnings.m4 b/m4/manywarnings.m4 > index 4f701f4ea..dfe5a5542 100644 > --- a/m4/manywarnings.m4 > +++ b/m4/manywarnings.m4 > @@ -142,7 +142,6 @@ AC_DEFUN([gl_MANYWARN_ALL_GCC], > -Wformat-security \ > -Wformat-signedness \ > -Wformat-y2k \ > - -Wformat-zero-length \ This is actually part of -Wall (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47901 ) , so this needs to be -Wno-format-zero-length, and belongs to m4/spice-compile-warnings.m4 rather than modifying this file. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel