Re: [PATCH qxl-wddm-dod v2] ci: Integrate with Appveyor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Frediano, thanks for review.
See below.


On 8 Jun 2017, at 13:42 PM, Frediano Ziglio <fziglio@xxxxxxxxxx> wrote:



Hello All,

This patch introduces Appveyor CI configuration file.

Having this patch pushed and qxl-wddm-dod repository registered at Appveyor,
every push or merge request will be automatically built on their servers.

If you need to comment a single patch to add explanation maybe this additional
explanation should be added to the commit message.

Yes, good idea. I will add.
Build status notifications will be sent to this list (spice-devel@xxxxxxxxxxxxxxxxxxxxx)
It seems that the message arrive as html with no corresponding test, see
Is possible to have pure text messages instead?

Probably yes, I will check if Appveyor supports this.
Best Regards,
Dmitry

On 8 Jun 2017, at 10:10 AM, Dmitry Fleytman <dmitry@xxxxxxxxxx> wrote:

Signed-off-by: Dmitry Fleytman <dmitry@xxxxxxxxxx>
---
.appveyor.yml | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 .appveyor.yml

diff --git a/.appveyor.yml b/.appveyor.yml
new file mode 100644
index 0000000..f3f3e5c
--- /dev/null
+++ b/.appveyor.yml
@@ -0,0 +1,18 @@
+image: Visual Studio 2015
+
This cause to stick to a version of images and if image are going to be removed in the
future this won't work. I use AppVeyor for another project and I know images are
updated and obsolete ones are removed after a while. From my experience is better to
fix the issues with the last machine version.

Not sure I understand. What do you mean by “last machine version”?

+version: build-{build}-{branch}
+
+before_build:
+  - ren "C:\Program Files (x86)\Windows Kits\10\include\00wdf" "wdf"
+
+build_script: buildAll.bat
+
+skip_commits:
+  message: /\[ci skip\]/
+
what does this?

A nice feature borrowed from Travis-CI - If commit message includes “[ci skip]” - CI is not run for this commit.


+notifications:
+  - provider: Email
+    to: spice-devel@xxxxxxxxxxxxxxxxxxxxx
Not strictly related to this patch, is usually a good idea to add sender e-mail
to the ML. Did you do it?

Not yet. I did not register upstream repository with Appveyor also.
Will do it after the patch is inside.

+    on_build_success: false
+    on_build_failure: true
+    on_build_status_changed: true
Frediano


_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]