Re: [PATCH spice-gtk v6 1/4] Add check for macOS and macOS specific define to allow ucontext

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 31 May 2017, at 17:50, Christophe de Dinechin <christophe@xxxxxxxxxxxx> wrote:


On 31 May 2017, at 17:31, Victor Toso <victortoso@xxxxxxxxxx> wrote:

Hi,

On Wed, May 31, 2017 at 05:18:03PM +0200, Christophe de Dinechin wrote:

On 31 May 2017, at 16:12, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:

On Wed, May 31, 2017 at 02:46:51PM +0200, Christophe de Dinechin wrote:
From: Christophe de Dinechin <dinechin@xxxxxxxxxx>

Signed-off-by: Christophe de Dinechin <dinechin@xxxxxxxxxx>
---
configure.ac | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/configure.ac b/configure.ac
index ff00d73..62acafc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -62,6 +62,18 @@ esac
AC_MSG_RESULT([$os_win32])
AM_CONDITIONAL([OS_WIN32],[test "$os_win32" = "yes"])

+AC_MSG_CHECKING([for native macOS])
+case "$host_os" in
+     *darwin*)
+        os_mac=yes
+        ;;
+     *)
+        os_mac=no
+        ;;
+esac
+AC_MSG_RESULT([$os_mac])


+AM_CONDITIONAL([OS_MAC],[test "$os_mac" = "yes"])

Is this OS_MAC useful at all?

It was useful initially before I added HAVE_EGL. And I think it will
be useful soon for Mac audio.

OT: Oh, gstaudio does not work well in mac client?

I just got video to work (and not that well), audio is next ;-) But no, so far, it does not work.

After a short discussion on IRC with Victor, it turns out that the problem is not that mac audio does not work, but rather that the volume sync mutes the source every time I launch mac spice. The sound stutters a lot, but there is sound.

Christophe


Christophe


I think it is cleaner to define it at
the time we add the mac in automake, because it keeps the Mac and
Windows code more similar.


Christophe
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]