Hi Jakub,
Those are really helpful, many thanks!
On Tue, May 30, 2017 at 05:39:07PM +0200, Pavel Grunt wrote:
> Hi Jakub,
>
> you should also list these in the comment describing the data type of
> the result (the data type here is "none" but the comment lists results
> covered by VD_AGENT_CAP_FILE_XFER_DETAILED_ERRORS) - sorry I forgot to
> mention that in the first review.
>
> Besides that it looks good to me.
>
> Thanks,
> Pavel
>
>
> On Mon, 2017-05-29 at 16:24 +0200, Jakub Janků wrote:
> > Introduce new error statuses to report more info to clients:
> > VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED,
> > VD_AGENT_FILE_XFER_STATUS_AGENT_NOT_CONNECTED,
It might get too big but I would change
- VD_AGENT_FILE_XFER_STATUS_AGENT_NOT_CONNECTED
+ VD_AGENT_FILE_XFER_STATUS_SESSION_AGENT_NOT_CONNECTED
or
+ VD_AGENT_FILE_XFER_STATUS_VDAGENT_NOT_CONNECTED
Maybe the later is better? IMHO we might have more and more agents in
the future and they might be talking to vdagentd or not (which I prefer
to call as system agent).
Anyway, I'm not really good with names so maybe someone will disagree
here.. :)
Cheers,
> > VD_AGENT_FILE_XFER_STATUS_DISABLED
> >
> > These are only sent to clients that feature
> > VD_AGENT_CAP_FILE_XFER_DETAILED_ERRORS capability.
> > ---
> > spice/vd_agent.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/spice/vd_agent.h b/spice/vd_agent.h
> > index 2a168d0..d5be6f7 100644
> > --- a/spice/vd_agent.h
> > +++ b/spice/vd_agent.h
> > @@ -100,6 +100,9 @@ enum {
> > VD_AGENT_FILE_XFER_STATUS_ERROR,
> > VD_AGENT_FILE_XFER_STATUS_SUCCESS,
> > VD_AGENT_FILE_XFER_STATUS_NOT_ENOUGH_SPACE,
> > + VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED,
> > + VD_AGENT_FILE_XFER_STATUS_AGENT_NOT_CONNECTED,
> > + VD_AGENT_FILE_XFER_STATUS_DISABLED,
> > };
> >
> > typedef struct SPICE_ATTR_PACKED VDAgentFileXferStatusMessage {
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel