Re: [PATCH v4 3/3] Add configure option for --enable-alignment-checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Small enough that I would squash this with the first patch. If you
want to split things in smaller bits, I think I'd go with a patch
introducing the alignment macro, and one making use of them. This way,
the patch using these macros in spice-gtk does not depend on the patch
using the macros in spice-common being acked first.

Christophe

On Tue, May 30, 2017 at 02:51:51PM +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin <dinechin@xxxxxxxxxx>
> 
> Signed-off-by: Christophe de Dinechin <dinechin@xxxxxxxxxx>
> ---
>  configure.ac | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 6d9f378..efd7317 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -28,6 +28,14 @@ AM_PROG_CC_C_O
>  
>  SPICE_CHECK_SYSDEPS
>  
> +AC_ARG_ENABLE([alignment-checks],
> +  AS_HELP_STRING([--enable-alignment-checks],
> +                 [Enable runtime checks for cast alignment @<:@default=no@:>@]),
> +  [],
> +  enable_alignment_checks="no")
> +AS_IF([test "x$enable_alignment_checks" = "xyes"],
> +      [AC_DEFINE([SPICE_DEBUG_ALIGNMENT], 1, [Enable runtime checks for cast alignment])])
> +
>  # Checks for libraries
>  PKG_CHECK_MODULES([PROTOCOL], [spice-protocol >= 0.12.12])
>  
> -- 
> 2.11.0 (Apple Git-81)
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]