May be a comment like "Use correctly ucontext for coroutines under Mac OS X Mac OS X requires _XOPEN_SOURCE to be defined in order to use ucontext type coroutines" > > On Wed, May 31, 2017 at 04:20:37AM -0400, Frediano Ziglio wrote: > > It's used by the build, setting with_coroutine change some conditional > > compilation. But this is not in the "Add check for macOS" comment. > > > > I don't see any patch using the OS_MAC conditional, maybe should > > be removed or do you want it for coherence with OS_WIN32 ? > > Ah right, did not pay close attention to the patch, most of it is > useful, and I was indeed asking about OS_MAC use. > > Christophe > > > > > Frediano > > > > > > > > Is this used by a patch in this series though? I'd rather we delay this > > > until this gets used. > > > > > > Christophe > > > > > > On Tue, May 30, 2017 at 02:52:47PM +0200, Christophe de Dinechin wrote: > > > > From: Christophe de Dinechin <dinechin@xxxxxxxxxx> > > > > > > > > Signed-off-by: Christophe de Dinechin <dinechin@xxxxxxxxxx> > > > > --- > > > > configure.ac | 15 +++++++++++++++ > > > > 1 file changed, 15 insertions(+) > > > > > > > > diff --git a/configure.ac b/configure.ac > > > > index ff00d73..62acafc 100644 > > > > --- a/configure.ac > > > > +++ b/configure.ac > > > > @@ -62,6 +62,18 @@ esac > > > > AC_MSG_RESULT([$os_win32]) > > > > AM_CONDITIONAL([OS_WIN32],[test "$os_win32" = "yes"]) > > > > > > > > +AC_MSG_CHECKING([for native macOS]) > > > > +case "$host_os" in > > > > + *darwin*) > > > > + os_mac=yes > > > > + ;; > > > > + *) > > > > + os_mac=no > > > > + ;; > > > > +esac > > > > +AC_MSG_RESULT([$os_mac]) > > > > +AM_CONDITIONAL([OS_MAC],[test "$os_mac" = "yes"]) > > > > + > > > > AC_CHECK_HEADERS([sys/socket.h netinet/in.h arpa/inet.h]) > > > > AC_CHECK_HEADERS([termios.h]) > > > > AC_CHECK_HEADERS([epoxy/egl.h], > > > > @@ -468,6 +480,9 @@ esac > > > > if test "$with_coroutine" = "auto"; then > > > > if test "$os_win32" = "yes"; then > > > > with_coroutine=winfiber > > > > + elif test "$os_mac" = "yes"; then > > > > + with_coroutine=ucontext > > > > + AC_DEFINE([_XOPEN_SOURCE], [1], [Define _XOPEN_SOURCE on macOS for > > > > ucontext]) Maybe this line require a comment too? > > > > else > > > > with_coroutine=ucontext > > > > fi > Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel