On Wed, May 17, 2017 at 03:44:48AM -0400, Frediano Ziglio wrote: > If these 2 hits you are going to have a message for every single pixel > in the image, potentially millions. > I'm still convinced, like in this case, that if we are sure that data > should be aligned no check and warning should be done. > I'm really sure no architecture on hearth can do check and print in > a single machine instruction. Actually I don't know any architecture > where a single check like this can be done in a single instruction. I was keeping this comment for the review of the spice-common patches introducing the macros, but I indeed wanted to ask about the performance impact of the macros, and whether we really need to always do the checks, or if we should only do these when debug mode is enabled at build time. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel