>
> From: Victor Toso <me@xxxxxxxxxxxxxx>
>
> Removing a comment in the code that says that incomplete GstCaps could
> trigger errors as this seems to be working fine. We should include all
> necessary parameters based on spice-protocol. At this time, the
> information we have from protocol is the stream-type which this patch
> includes.
>
> Any other errors to h264 format should either be reported to
> GStreamer or fixed by improving the spice-protocol.
>
> The follow up patch will identify elements in GstRegistry based on
> GstCaps so this is a necessary change to have.
>
> This is also a preparatory patch to use Playbin element to create the
> pipeline. Without this, Playbin or typefind will fail to recognize the
> stream as H264.
>
> Signed-off-by: Victor Toso <victortoso@xxxxxxxxxx>
> Signed-off-by: Victor Toso <me@xxxxxxxxxxxxxx>
Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
> src/channel-display-gst.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
> index 9b79403..8546167 100644
> --- a/src/channel-display-gst.c
> +++ b/src/channel-display-gst.c
> @@ -71,11 +71,11 @@ static struct {
> */
> { "vp8dec", "caps=video/x-vp8" },
>
> - /* SPICE_VIDEO_CODEC_TYPE_H264
> - * h264 streams detection works fine and setting an incomplete cap
> - * causes errors. So let typefind do all the work.
> - */
> - { "h264parse ! avdec_h264", "" },
> + /* SPICE_VIDEO_CODEC_TYPE_H264 */
> + /* We need the caps for Playbin. We could also add
> "stream-format=byte-stream"
> + * as we set that in spice-server but we might want to have support to
> + * different stream-format */
> + { "h264parse ! avdec_h264", "caps=video/x-h264" },
>
> /* SPICE_VIDEO_CODEC_TYPE_VP9 */
> { "vp9dec", "caps=video/x-vp9" },
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel