Re: [PATCH spice-gtk 1/4] Avoid clang warnings on casts with stricter alignment requirements

[Christophe de Dinechin <dinechin@xxxxxxxxxx>]

On 11 May 2017, at 11:17, Frediano Ziglio <fziglio@xxxxxxxxxx> wrote:

...

  g_array_set_size(c->remote_common_caps, num_common_caps);
  for (i = 0; i < num_common_caps; i++, caps++) {

I cannot find these macros defined in spice-gtk. Where are they?

spice-common. I think I announced it in the envelope mail for the patch. That’s why there is a submodule update. I don’t know if this is the right way to do things for submodule required changes.

You should send the changeset with spice-common with the other changesets (so the mail to the ML).

You mean I should add a link for example https://lists.freedesktop.org/archives/spice-devel/2017-May/037505.html to the description? Or make a single patch set with changes both in spice-common and spice-gtk. If the latter, I don’t know how…

Also the spice-gtk changes should include a change to spice-common submodule.

I see it in https://lists.freedesktop.org/archives/spice-devel/2017-May/037509.html:

diff --git a/spice-common b/spice-common
index af682b1..1239c82 160000
--- a/spice-common
+++ b/spice-common
@@ -1 +1 @@
-Subproject commit af682b1b06dea55007d9aa7c37cd443e4349e43f
+Subproject commit 1239c82c54dee0244cca262cca0aa21071b23e24

Or do you mean something else?

(BTW, I sent an updated series with your comments, still not showing up, so I guess my mail setup is still not good enough)

Thanks

Christophe

Frediano

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel