Re: [client v2 5/5] streaming: Separate the network code from the display_stream management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 9 May 2017, Christophe Fergeau wrote:
[...]
> > So I'd propose another variant where display_stream_create() takes a 
> > rect parameter but leaves clip to its default. See the attached patch. 
> > Feel free to pick any of the three variants.
> 
> In the current code, clip is not really optional as it's unconditionally
> set after calling display_stream_create().

It is in the sense that if you were to remove the code setting it on the 
caller side, the stream code would not behave erratically due to invalid 
or uninitialized data.


> I'll push with my variant, and we can revise how this all works and 
> make this optional when/if the code you alude to gets public :)

Sure. That totally works for me!


-- 
Francois Gouget <fgouget@xxxxxxxxxxxxxxx>
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]