On Tue, Apr 11, 2017 at 08:54:15AM -0400, Frediano Ziglio wrote:
> >
> > red_channel_client_start_ping_timer(),
> > red_channel_client_cancel_ping_timer(),
> > red_channel_client_restart_ping_timer() are no-ops when
> > rcc->priv->latency_monitor.timer is NULL, so there is no need to
> > explicitly check it's not NULL before calling these functions.
> >
> > Signed-off-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
>
> Looking at code it seems the check is moved, not removed.
I've changed the commit log to:
Remove unneeded rcc->priv->latency_monitor.timer checks
Beforoe this commit, red_channel_client_start_ping_timer() and
red_channel_client_cancel_ping_timer() had checks to be no-ops when
rcc->priv->latency_monitor.timer is NULL.
This commit adds a similar check to
red_channel_client_restart_ping_timer(), and removes explicit NULL
checks before calls to red_channel_client_{cancel,restart,start}_ping_timer()
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel