red_channel_client_msg_sent() always clears the rcc->priv->send_data.blocked flag. Hower, towards the end of it, there is a if (!red_channel_client_is_blocked()) test, which will always be true, so it can be removed. This check was already redundant when it was introduced in 9a62a9a809eaf0 Signed-off-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> --- server/red-channel-client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/server/red-channel-client.c b/server/red-channel-client.c index 0b04c96..733ce18 100644 --- a/server/red-channel-client.c +++ b/server/red-channel-client.c @@ -652,8 +652,7 @@ static void red_channel_client_msg_sent(RedChannelClient *rcc) spice_assert(rcc->priv->send_data.header.data != NULL); red_channel_client_begin_send_message(rcc); } else { - if (!red_channel_client_is_blocked(rcc) - && g_queue_is_empty(&rcc->priv->pipe)) { + if (g_queue_is_empty(&rcc->priv->pipe)) { /* It is possible that the socket will become idle, so we may be able to test latency */ red_channel_client_restart_ping_timer(rcc); } -- 2.9.3 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel