On Fri, Apr 07, 2017 at 03:38:05PM -0500, Jonathon Jongsma wrote:
> On Fri, 2017-04-07 at 16:31 +0200, Christophe Fergeau wrote:
> > ---
> > server/red-channel-client.c | 32 ++++++++++++++++----------------
> > 1 file changed, 16 insertions(+), 16 deletions(-)
> >
> > diff --git a/server/red-channel-client.c b/server/red-channel-
> > client.c
> > index c988170..eae5794 100644
> > --- a/server/red-channel-client.c
> > +++ b/server/red-channel-client.c
> > @@ -67,8 +67,15 @@ struct SpiceDataHeaderOpaque {
> > get_msg_size_proc get_msg_size;
> > };
> >
> > +enum QosPingState {
> > + PING_STATE_NONE,
> > + PING_STATE_TIMER,
> > + PING_STATE_WARMUP,
> > + PING_STATE_LATENCY,
> > +};
> > +
>
> Any particular reason that you didn't typedef this enum?
>
> e.g.
>
> typedef enum {
> ...
> } QosPingState;
>
> Looking through the rest of the code, I can't find any other
> occurrences of something like the following:
>
> enum enumName var_name;
>
> So for consistency, I'd prefer to typedef the enum.
Oh, for sure, I considered doing it, and lazily went for simple code
movement with no other change. I'll definitely change it to a typedef.
Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel