Re: [spice-common] log: Add missing stdio.h include

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2017-03-31 at 12:03 +0200, Christophe Fergeau wrote:
> On Fri, Mar 31, 2017 at 11:50:34AM +0200, Pavel Grunt wrote:
> > On Fri, 2017-03-31 at 05:36 -0400, Frediano Ziglio wrote:
> > > > 
> > > > This is needed because spice_printerr uses fprintf/stderr
> > > > ---
> > > >  common/log.h | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/common/log.h b/common/log.h
> > > > index 0e03f59..11261ca 100644
> > > > --- a/common/log.h
> > > > +++ b/common/log.h
> > > > @@ -18,6 +18,8 @@
> > > >  #ifndef H_SPICE_LOG
> > > >  #define H_SPICE_LOG
> > > >  
> > > > +#include <stdio.h>
> > > > +
> > 
> > per spice style there should not be this empty line
> 
> Looks like more moving around would be needed if we want to be
> consistent with the style guide:

imho it is enough to follow the style for the new code, we don't need
to fix everything at once

> 
> #include <stdarg.h>
> #include <stdio.h>
> #include <glib.h>
> #include <spice/macros.h>
> 
> #include "macros.h"
> 
> Christophe
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]