Re: [PATCH spice] ci: Add valgrind check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> ---
>  .gitlab-ci.yml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 1c5e37c3..c54516f1 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -20,6 +20,14 @@ statistics:
>    - make
>    - make -C server check || (cat server/tests/test-suite.log && exit 1)
>  
> +check-valgrind:
> +  script:
> +  - dnf debuginfo-install spice-server -y
> +  - dnf install valgrind -y
> +  - ./autogen.sh --enable-valgrind
> +  - make
> +  - make check-valgrind || (cat server/tests/test-suite-memcheck.log && exit
> 1)
> +
>  syntax-check:
>    script:
>    - ./autogen.sh

Looks good. And I remember you posted a successful build link so
it's working.

Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx>

I was thinking if we are not spending too much GitLab resources
but I don't see any way to bound together some checks. The main one
uses sanitizer that is not compatible. The statistics does not make
much sense to join with valgrind.

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]