On Mon, Mar 20, 2017 at 02:05:13PM -0400, Frediano Ziglio wrote:
> >
> > On Fri, Mar 17, 2017 at 02:10:22PM +0100, Pavel Grunt wrote:
> > > > +
> > > > +static void deinit_qxl_surface(QXLSurfaceCmd *qxl)
> > > > +{
> > > > + free((void *)qxl->u.surface_create.data);
> > >
> > > `make syntax-check` is failing because of this
> >
> > Ah, thanks, it also fails after this patch because of the #include
> > <assert.h>. I've removed the cast and the include.
> >
> > However the @VALGRIND_CHECK_RULES@ added in the next patch also breaks
> > make syntax-check, I'll address this too :)
> >
> > Christophe
> >
>
> Sorry, was going to say, this line also will fail due to a
> warning using 32 bit, should be
>
> free((void *)(uintptr_t)qxl->u.surface_create.data);
>
> or even define a from_physical (like to_physical) even to avoid
> the syntax-check problem
Yes, I went with a helper function
Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel