On Fri, Mar 10, 2017 at 09:18:31AM -0500, Frediano Ziglio wrote: > > > > This allows to run automatically our test-suite with valgrind to test > > for memory leaks. > > If this is a reply to test-leaks question from Christphe D > I usually use address sanitizer now :) > > I didn't check/test the patch but I'm seeing it has GNU make > specific stuff. From another patch this morning seems we support > *BSD but the README file state to use make which in *BSD is not > the GNU one. I'm fine with letting someone provide a patch fixing that, or saying gmake should be used ;) > > > --- > > This adds the target suggested in > > https://lists.freedesktop.org/archives/spice-devel/2017-March/036499.html > > Half of the tests are currently failing when using make check-valgrind, I > > haven't tried to fix them. > > > > A reason for a nack I would say. Unless followed by a fix. > We never follow such a test based way (some agile methodology suggest this > way) but indeed the opposite, fix before test to avoid git blame issues. I can differ this until I have looked at fixing the failures, in this case since there is no changes to the default build/a defaut test run, so I don't think it's really a problem to have this patch without the fixes. Makes it easy to trigger the failures for anyone who would want to look at it. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel