Re: [PATCH spice-server v4 3/3] red-channel: Use RedChannelCapabilities directly to pass capabilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 02, 2017 at 10:15:15AM -0500, Frediano Ziglio wrote:
> > Not really a big fan of having this kind of functions because we use
> > stack-allocated struct rather than just allocating a new struct. This
> > function should only be used on non-initialized RedChannelCapabilities
> > (this will leak otherwise), but it's non-obvious from the function name.
> > 
> 
> Maybe red_channel_capabilities_init_from_link_message ?

Better I guess,

Christophe

> 
> > 
> > Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> > 
> > Christophe
> > 
> 
> Frediano

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]