On Tue, Feb 28, 2017 at 09:43:33AM +0000, Frediano Ziglio wrote: > Capabilities where almost always passed using 2 arguments, > a number of elements and an array but then before using > these were converted to a GArray. > Converting to GArray much earlier allows to easily pass > the capabilities around. Hey, nice improvement! > > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > --- > I don't know if is worth defining an abstract type > instead of using a simple GArray. > Maybe a "typedef GArray RedCapabilities" could help future > replacement of the GArray? There's already a RedChannelCapabilities in red-channel.h, I'd reuse this one. > On the other side this patch moves most of the array boxing > into a single function. I'd create the GArray one level higher, in reds_channel_do_link() rather than red_channel_connect, let reds.c do the grunt work, and have RedChannel deal with higher level types. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel