Re: [PATCH spice-protocol 2/2] agent: Add macro for clearing capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> Related:
> https://bugzilla.redhat.com/show_bug.cgi?id=1373725
> ---
>  spice/vd_agent.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/spice/vd_agent.h b/spice/vd_agent.h
> index ac22498..3b1f183 100644
> --- a/spice/vd_agent.h
> +++ b/spice/vd_agent.h
> @@ -269,6 +269,9 @@ typedef struct SPICE_ATTR_PACKED
> VDAgentAnnounceCapabilities {
>  #define VD_AGENT_SET_CAPABILITY(caps, index) \
>      { (caps)[(index) / 32] |= (1 << ((index) % 32)); }
>  
> +#define VD_AGENT_CLEAR_CAPABILITY(caps, index) \
> +    { (caps)[(index) / 32] &= ~(1 << ((index) % 32)); }
> +
>  #include <spice/end-packed.h>
>  
>  #endif /* _H_VD_AGENT */

I would say

Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx>

Honestly I don't think should be a 2/2, just a separate patch.

The related bug comment for a so generic patch looks a bit weird.

Would be sensible to have a static inline function instead of
a macro?

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]