Re: [PATCH spice-server] style: Specify boolean style convention

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 27, 2017 at 07:04:30AM -0500, Frediano Ziglio wrote:
> > 
> > On Mon, Feb 27, 2017 at 06:36:18AM -0500, Frediano Ziglio wrote:
> > > What about:
> > > 
> > > "style: Change boolean style convention
> > > 
> > > Was agreed to use C99 syntax for boolean.
> > > New code should attempt to follow the new style."
> > 
> > "Following
> > https://lists.freedesktop.org/archives/spice-devel/2017-February/035800.html
> > , the consensus was to use 'bool' rather than 'gboolean', and to use
> > true/false rather than TRUE/FALSE. New code should attempt to follow the
> > new style."
> > 
> > Christophe
> > 
> 
> "and to use true/false rather than TRUE/FALSE." is maybe misleading.
> Few places where it's another type should stay consistent with the type
> (unless I didn't understand).

Imo it's fine not to be 100% accurate in the commit log, the actual
change has all the details.

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]