On Wed, Feb 15, 2017 at 06:45:21AM -0500, Frediano Ziglio wrote:
> >
> > Some debug messages were using spice_printerr(), which should be limited
> > to actual errors.
> >
> > Signed-off-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> > ---
> > server/inputs-channel.c | 4 ++--
> > server/main-channel-client.c | 28 ++++++++++++++--------------
> > server/main-channel.c | 10 +++++-----
> > server/red-channel-client.c | 4 ++--
> > server/red-client.c | 4 ++--
> > server/red-qxl.c | 12 ++++++------
> > server/smartcard.c | 2 +-
> > server/spicevmc.c | 2 +-
> > 8 files changed, 33 insertions(+), 33 deletions(-)
> >
> > diff --git a/server/inputs-channel.c b/server/inputs-channel.c
> > index 3672d7e..89fb90e 100644
> > --- a/server/inputs-channel.c
> > +++ b/server/inputs-channel.c
> > @@ -516,7 +516,7 @@ static void inputs_connect(RedChannel *channel, RedClient
> > *client,
> > "keyboard channel is insecure");
> > }
> >
> > - spice_printerr("inputs channel client create");
> > + spice_debug("inputs channel client create");
> > rcc = inputs_channel_client_create(channel, client, stream, FALSE,
> > num_common_caps, common_caps,
> > num_caps, caps);
>
> agreed
>
> > @@ -714,7 +714,7 @@ int inputs_channel_has_tablet(InputsChannel *inputs)
> >
> > void inputs_channel_detach_tablet(InputsChannel *inputs, SpiceTabletInstance
> > *tablet)
> > {
> > - spice_printerr("");
> > + spice_debug("");
> > inputs->tablet = NULL;
> > }
> >
>
> I vote to remove
I prefer that this is done in a separate patch, would be a good
opportunity to take a look at the spice_debug(NULL) that we have (as
well as an odd-looking spice_debug("%s", "")).
Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel