On Wed, 2017-02-22 at 14:11 +0100, Victor Toso wrote:
> From: Victor Toso <me@xxxxxxxxxxxxxx>
>
> In case of failure,
Do we want to know about the failure?
> the GdkAtom *atoms will be set to NULL.
> Including this check to an early return.
>
> Signed-off-by: Victor Toso <victortoso@xxxxxxxxxx>
> ---
> src/spice-gtk-session.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c
> index 0426d8f..3c78e6a 100644
> --- a/src/spice-gtk-session.c
> +++ b/src/spice-gtk-session.c
> @@ -604,7 +604,8 @@ static void clipboard_get_targets(GtkClipboard
> *clipboard,
> {
> SpiceGtkSession *self = free_weak_ref(user_data);
>
> - if (self == NULL)
> +
> + if (self == NULL || atoms == NULL)
> return;
Maybe add a comment ? no atoms => no targets
>
> g_return_if_fail(SPICE_IS_GTK_SESSION(self));
OT: these checks for 'self' are strange - the first one hides the
other
Pavel
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel