Re: [PATCH spice-gtk v4 6/6] usb-device-widget: Migrate to GtkContainer from GtkBox

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 14, 2017 at 07:05:18PM +0100, Pavel Grunt wrote:
> GtkVBox is deprecated since Gtk 3.2, GtkBox is going to be
> deprecated. Just use the GtkContainer api.
> ---
> Per the commit bc3d12efb20423d5b1ebd490658f687c4bd323fd the class is considered final,
> so this shouldn't be an ABI break
> 
> If we consider it as the ABI break we can just use the GtkContainer api

Oh, if the SpiceUsbDeviceWidget structure is not exposed in public
headers, it's definitely not an ABI break. The only think I can think of
which would cause a difference in behaviour is if some code is
directly using SpiceUsbDeviceWidget as a GtkBox, but hopefully this is
not done?

I'd Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> this

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]