Re: [spice-server v2 14/14] rcc: Consistently name RedChannelClient 'rcc'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2017-02-15 at 08:51 +0100, Christophe Fergeau wrote:
> On Tue, Feb 14, 2017 at 12:14:56PM -0600, Jonathon Jongsma wrote:
> > To be honest, I could go either way on this one. I like the
> > consistency, but I don't like the fact that it makes things like
> > "git
> > blame" less useful. I'll leave the decision to others ;)
> 
> I've pushed the series without this patch for now, 'self' is only
> used
> in GObject boilerplate, so the inconsistency is not too bad (at least
> the patch series itself did not add more inconsistencies this time).
> On the other hand, 'tig blame' and the ',' shortcut help a lot making
> git blame useful even with such commits.
> 
> Christophe


Brilliant. I have been using 'tig' for a while but didn't know about
the blame view, nor did I know about the ',' shortcut. That makes
things much easier. Thanks for the tip. 

Jonathon
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]