On Wed, Feb 15, 2017 at 03:23:36PM +0100, Pavel Grunt wrote: > On Wed, 2017-02-15 at 15:16 +0100, Christophe Fergeau wrote: > > On Wed, Feb 15, 2017 at 09:14:10AM -0500, Frediano Ziglio wrote: > > > > > > > > On Wed, Feb 15, 2017 at 06:39:13AM -0500, Frediano Ziglio wrote: > > > > > > > > > > Patch is good however the use of bool is inconsistent. > > > > > Although I _much_ prefer bool/true/false we decided for > > > > > gboolean/TRUE/FALSE. > > > > > > > > reds-stream.[ch] is already exclusively using bool instead of > > > > gboolean, > > > > so I'd prefer to stick with this. I have a patch (series) in > > > > preparation > > > > changing gboolean to bool (with justification), so I would not > > > > change > > > > reds-stream.[ch] just yet. > > > > > > > > Christophe > > > > > > > > > > Can you be at least consistent in server/reds-stream.c ? > > > > > > bool -> true/false > > > > > > > Existing code already uses bool together with TRUE/FALSE, so I would > > keep the discussion about TRUE vs true for another time as well ;) > > > > I am against mixing, TRUE&FALSE is gboolean, true&false is bool > I agree it's odd, but this is what reds-stream.c is already doing, I'd prefer to keep things consistent for now, even though it's weird. > imo it is simple: spice server requires C99 => we have stdbool => we > can use it if it has benefits I'll send a patch series related to that, imo we talk about that in relation with that new series. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel