Re: [PATCH spice-server 2/4] Do not set TCP_NODELAY flag twice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 15, 2017 at 06:48:32AM -0500, Frediano Ziglio wrote:
> > 
> > On Wed, Feb 15, 2017 at 11:31:59AM +0000, Frediano Ziglio wrote:
> > > TCP_NODELAY flag is set by default for all connection inside
> > > reds.c so there's no need to set again for the single
> > > client channel.
> > 
> > Would have been nice to keep "Do not set not blocking flag twice"
> > together with this patch, and push them at the same time..
> > 
> > > 
> > > Note that there are still some call to setsockopt to set this
> > > option but in this case the flag can reset the flag.
> > 
> > 'some calls'
> > the flag can reset the flag?
> > 
> 
> Yes, confusing, what about:
> 
> "Note that there are still some call to setsockopt to change this
> option."

"some calls", and yes, much clearer :)

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]