Re: [PATCH spice-server 2/4] Do not set not blocking flag twice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 14, 2017 at 10:16:43AM -0500, Frediano Ziglio wrote:
> > 
> > On Mon, Feb 13, 2017 at 11:03:17AM +0000, Frediano Ziglio wrote:
> > > Non blocking flag is set for all connection inside reds.c so
> > > there's no need to set again for the single client channel.
> > > 
> > > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> > 
> > I'd move that code in a RedsStream helper while at it, I can send a
> > patch if you want.
> > 
> > Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> > 
> > Christophe
> > 
> 
> Agreed. Better by the way in a follow up, this just remove lines
> but do not change where the setting is done.

Yup, agreed, hence the ACK here, and the proposal to send a patch ;)

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]