On Wed, Feb 08, 2017 at 12:54:44PM -0600, Jonathon Jongsma wrote: > On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote: > > Similarly to the previous commits, this removes an indirection level, > > IncomingHandlerInterface stores pointers to > > alloc_recv_buf/release_recv_buf vfuncs, but these are always set to > > RedChannel::alloc_recv_buf/RedChannel::release_recv_buf, which are > > also > > vfuncs which can be overridden if needed. This commit removes the > > indirection and directly calls the relevant methods. > > > > Not sure whether the corresponding vfuncs belong in > > RedChannel or if they should be moved to RedChannelClient. > > They do seem more appropriate to RedChannelClient, since the first > argument is RedChannelClient*. If we do move them, it could be done in > a subsequent commit, though. Maybe more of this stuff should be moved > to the client? A bit involved to move (eg the callbacks in CommonDisplayChannel uses a buffer from CommonDisplayChannelPrivate, and there is no CommonDisplayChannelClient, ...), so I'd leave that as improvements for another time ;) Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel