On Fri, Feb 10, 2017 at 04:23:46AM -0500, Frediano Ziglio wrote: > > > > On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote: > > > It was probably meant to be used as a "user_data" argument for the > > > various callbacks, but turns out not to be used. > > > > Hmm, it looks like the last use of this 'data' variable was removed in > > 96e94c6f. That commit used g_object_set_data() to attach the > > 'dispatcher' object to the channel object rather than setting priv- > > >data via the _register_client_cbs() function. I'm not too fond of > > g_object_set_data() for that use (even though apparently I was the one > > that did it). I wonder if there's a better approach than either of > > these approaches... I'll try to review the rest of the patches in this > > series and come back to this... > > > > Jonathon > > > > +1 > > Why not adding a data/opaque field to ClientCbs ? This series is just a part of a bigger branch ( https://cgit.freedesktop.org/~teuf/spice/log/?h=vfuncs ) which has a commit not so subtly named "die ClientCbs, die!", so I'd rather not add more stuff to ClientCbs. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel