Re: [spice-server 00/10] Remove IncomingHandlerInterface/OutgoingHandlerInterface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> Hey,
> 
> This patch series removes IncomingHandlerInterface and
> OutgoingHandlerInterface
> which added a layer of indirection between RedChannel/RedChannelClient which
> is no longer useful now that RedChannel/RedChannelClient are real classes.
> 
> Christophe
> 

I agree with most of the changes, not entirely with this rationale.
The indirection was useless even before the classes.
The indirection was meant to allows abstraction but this abstraction
was never used and not well defined. For instance there is a prepare_msg
which basically set some iovec but having all message system using
marshaller which is coded into RedChannelClient make the prepare_msg
implementation fixed (similar the other callbacks).

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]