Re: [PATCH spice-server 1/2] stat-file: Fix off by one buffer overflow

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Thu, 2017-02-02 at 10:52 -0600, Jonathon Jongsma wrote:
> > Acked-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>
> > 
> > Out of curiosity, how did you find it? Just reading code?
> 
> Nevermind. I see that the next patch is addressing a compiler warning
> in this code, so you were obviously looking closely at this code for
> that reason.
> 
> 

Yes and not.
As said in a previous mail one check in the code was duplicated
so I removed it but turns out that this caused the buffer
overflow to be triggered by the test (test-stat-file) which
was failing as the file was allocating 11 elements out of 10.

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]