Hey, On Thu, Jan 26, 2017 at 02:55:03AM -0500, Frediano Ziglio wrote: > > > > This is in preparation for making them inherit from RedChannelClient. > > Doing it in one go would result in a very huge commit, so this commit > > starts by turning these into GObjects, while still using a > > DummyChannelClient instance for sending the data. > > > > Based on a patch from Frediano Ziglio <fziglio@xxxxxxxxxx> > > > > Signed-off-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> > > IMO this patch is too artificial, I would merge to 10/10 To be honest, I'm a bit torn on this one. I totally agree that it's very artificial. On the other hand, it also reduces the per-commit changes in sound.c significantly: server/sound.c | 325 +++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------- and then server/sound.c | 262 ++++++++++++++++++++++++++----------------------------------------- VS server/sound.c | 411 +++++++++++++++++++++++++++++++++++++------------------------------ For the combined patch and we've got a more or less mechanical patch turning SndChannelClient into a GObject, and then another one removing SndChannelClient::channel_client. So not fully sure what is best between merging the two patches or not :-/ Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel