Re: [PATCH v6 1/5] Quiet uninitialized variable warning.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> Signed-off-by: Michal Suchanek <msuchanek@xxxxxxx>
> ---
> v2:
>  - use g_return_if_reached
> ---
>  src/vdagentd/vdagentd.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
> index a1faf23..e2d6159 100644
> --- a/src/vdagentd/vdagentd.c
> +++ b/src/vdagentd/vdagentd.c
> @@ -305,6 +305,8 @@ static void do_client_file_xfer(struct
> vdagent_virtio_port *vport,
>          id = d->id;
>          break;
>      }
> +    default:
> +        g_return_if_reached();
>      }
>  
>      conn = g_hash_table_lookup(active_xfers, GUINT_TO_POINTER(id));

This patch got different comments. Ack or nack?

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]