Re: [spice-server v2 06/10] sound: Remove code from spice_server_record_get_samples()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Tue, Jan 24, 2017 at 08:51:00AM -0500, Frediano Ziglio wrote:
> > > 
> > > It's ok to remove it because ?
> > > 
> > > Based on a patch from Frediano Ziglio <fziglio@xxxxxxxxxx>
> > > 
> > > Signed-off-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> > 
> > Because I hate polling and was removed time ago :)
> > 
> > Really, now RedChannelClient try to send/receive data when it can
> > reducing latency.
> > This code was here as it was possible that some data was still
> > pending on the receiving queue due to some polling so it
> > try to read queue directly if buffer was not fill correctly.
> 
> So before switching to RedChannelClient, this code should be needed, but
> after the switch, it can be removed because the polling is no longer
> necessary?
> 
> Christophe
> 

Even now. snd_receive is called by the event loop when data
are available (by snd_event).
Forcing another read seems a bit useless.

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]