[spice-server v2 1/2] stat: Silence gcc warning

[Christophe Fergeau <cfergeau@xxxxxxxxxx>]

Initializing 'node' to NULL silences this warning:

stat-file.c: In function 'stat_file_add_node':
stat-file.c:180:15: error: 'node' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     g_strlcpy(node->name, name, sizeof(node->name));
               ^~~~
cc1: all warnings being treated as errors

This warning is a false positive as this loop:
    for (ref = 0; ref <= stat_file->max_nodes; ref++) {
        node = &stat_file->stat->nodes[ref];
        ...
    }
will always iterate at least once.
---
 server/stat-file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/stat-file.c b/server/stat-file.c
index c23f4f5..de455b6 100644
--- a/server/stat-file.c
+++ b/server/stat-file.c
@@ -144,7 +144,7 @@ StatNodeRef
 stat_file_add_node(RedStatFile *stat_file, StatNodeRef parent, const char *name, int visible)
 {
     StatNodeRef ref;
-    SpiceStatNode *node;
+    SpiceStatNode *node = NULL;
 
     spice_assert(name && strlen(name) > 0);
     if (strlen(name) >= sizeof(node->name)) {
-- 
2.9.3

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel