On Thu, 2017-01-19 at 16:34 +0100, Victor Toso wrote: > Hi, > > On Thu, Jan 19, 2017 at 03:27:21PM +0100, Christophe Fergeau wrote: > > You need > > > > diff --git a/tools/Makefile.am b/tools/Makefile.am > > index 204dc50..0bdb3c5 100644 > > --- a/tools/Makefile.am > > +++ b/tools/Makefile.am > > @@ -2,6 +2,7 @@ bin_PROGRAMS = spicy-stats spicy-screenshot > > > > TOOLS_CPPFLAGS = \ > > -DSPICE_COMPILATION \ > > + -I$(top_builddir)/src \ > > -I$(top_srcdir) \ > > -I$(top_srcdir)/src \ > > $(COMMON_CFLAGS) \ > > > > or VPATH/make distcheck are broken (spice-glib-enums.h is generated > > during > > build, so it will be in $(top_builddir)/src) > > Right! > > > > > You also need this small change to po/POTFILES.in for make > > distcheck > > > > diff --git a/po/POTFILES.in b/po/POTFILES.in > > index db42281..d1033f9 100644 > > --- a/po/POTFILES.in > > +++ b/po/POTFILES.in > > @@ -2,8 +2,8 @@ src/channel-main.c > > src/channel-usbredir.c > > src/desktop-integration.c > > src/spice-channel.c > > -src/spice-cmdline.c > > src/spice-option.c > > src/usb-device-manager.c > > src/usb-device-widget.c > > src/usbutil.c > > +tools/spice-cmdline.c > > > > With that squashed in, > > Sure, thanks! > > > > > Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> > > > > unless someone else thinks moving these is a bad idea. > > > > Christophe > > No problem, I'll wait till Monday to push this, just in case. > For what it's worth, I have no objections. Jonathon _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel