On Tue, 2016-12-06 at 10:49 +0100, Christophe Fergeau wrote: > On Mon, Dec 05, 2016 at 04:19:04PM -0600, Jonathon Jongsma wrote: > > > > The spice_marshaller_add_ref() family of functions is confusing > > since it > > sounds like you're incrementing a reference on the marshaller. What > > it > > is actually doing is adding a data buffer to the marshaller by > > reference > > rather than by value. Changing the function names to _add_by_ref() > > makes > > this clearer. > > > > The old functions are deprecated and are simply inline functions > > that > > call the new functions. > > Do we have to keep the old ones? > > Christophe probably not if we update all of the repositories that use the old function. But I figured it was kinder to do it this way for at least a little while to ease the transition. Jonathon _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel