Re: [PATCH v4 06/17] sound: Implements config_socket RedChannel callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Thu, Dec 01, 2016 at 03:43:01PM -0600, Jonathon Jongsma wrote:
> > On Thu, 2016-12-01 at 11:24 +0000, Frediano Ziglio wrote:
> > > This code is the same inside __new_channel but will set the
> > > RedsStream from RedChannel.
> > 
> > Shouldn't this code be removed from __new_channel() then?
> 
> I agree that this would make things it more obvious what's going on by
> looking at the diff. Unless __new_channel is still used for now, and
> removing this breaks things.
> 
> Christophe
> 
> 

Should I merge into the GObject patch then?

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]