On Fri, Dec 02, 2016 at 06:37:26PM +0100, Victor Toso wrote: > > I prefer accessors. > > Should I drop also the change from G_PARAM_WRITABLE to > G_PARAM_READWRITE or should I drop the patch entirely? You can go with both :) > > > Also streaming code should have access to this information, in all > > other DisplayChannel code video_codecs are useless. > > That is the problem is that stream data are in DisplayChannel, > > I think the right direction is encapsulate correctly stream code, > > data related to stream should be in a "stream" structure. > > > > Frediano > > Indeed, it seems that it can be improved but I'm not sure how it should > be designed? > > Nowadays: > > host calls reds:spice_server_set_video_codecs() that calls > reds_on_vc_change() which end up sending Fwiw, method named reds_on_yyy() might be good candidate for using a signal rather than a function call now that we have more GObjects. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel