Re: [PATCH v4 04/17] sound: Rename SndWorker to SndChannel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Thu, Dec 01, 2016 at 11:24:26AM +0000, Frediano Ziglio wrote:
> > @@ -1506,73 +1506,73 @@ static void remove_worker(SndWorker *worker)
> >  
> >  void snd_attach_playback(RedsState *reds, SpicePlaybackInstance *sin)
> >  {
> > -    SndWorker *playback_worker;
> > -    RedChannel *channel;
> > +    SndChannel *playback;
> > +    RedChannel *red_channel;
> 
> Here s/channel/red_channel was not really necessary as the other
> variable is named "playback" and not channel, ditto in snd_attach_record
> below.
> 

Should I revert them?

> Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> 
> Christophe

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]