On Wed, 23 Nov 2016, Christophe Fergeau wrote:
> On Wed, Nov 23, 2016 at 07:09:28AM +0100, Francois Gouget wrote:
> > For Spice-gtk most deprecation issues come from changes outside Spice
> > (GLib) and thus should not be treated as errors to not break
> > compilation for users who have newer third-party libraries.
> > However they must be visible otherwise Spice developers will not be
> > aware of them and thus will not fix them before breakage happens.
>
> Also iirc -DXXX_VERSION_MIN_REQUIRED=yyy need deprecation warnings to be
> functional
Hmmm, I applied the patch below and I'm getting errors with or without
this patchset.
diff --git a/configure.ac b/configure.ac
index f3e7f8d..4661e9f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -136,7 +136,7 @@ AS_IF([test "x$with_gtk" != "xno"],
[AS_IF([test "x$os_win32" = "xyes"],
[PKG_CHECK_MODULES(GTK, gtk+-3.0 >= $GTK_REQUIRED)],
[PKG_CHECK_MODULES(GTK, gtk+-3.0 >= $GTK_REQUIRED epoxy)])]
- [GTK_CFLAGS="$GTK_CFLAGS -DGDK_VERSION_MIN_REQUIRED=$GTK_ENCODED_VERSION \
+ [GTK_CFLAGS="$GTK_CFLAGS -DGDK_VERSION_MIN_REQUIRED=4 \
-DGDK_VERSION_MAX_ALLOWED=$GTK_ENCODED_VERSION"])
SPICE_GTK_REQUIRES="${SPICE_GTK_REQUIRES} gtk+-3.0 >= $GTK_REQUIRED"
Btw, what's the status of this patchset?
--
Francois Gouget <fgouget@xxxxxxxxxxxxxxx>
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel