Re: [PATCH spice-server] Add a comment to red_channel_client_init_send_data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 24, 2016 at 10:48:24AM +0000, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
>  server/red-channel-client.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/server/red-channel-client.h b/server/red-channel-client.h
> index 94b4f58..93d0315 100644
> --- a/server/red-channel-client.h
> +++ b/server/red-channel-client.h
> @@ -89,6 +89,9 @@ void red_channel_client_shutdown(RedChannelClient *rcc);
>  int red_channel_client_handle_message(RedChannelClient *rcc, uint32_t size,
>                                        uint16_t type, void *message);
>  /* when preparing send_data: should call init and then use marshaller */
> +/* item is retained as long as the message is sent to the client,

"The item is retained", then I don't understand when the item stops
being retained. "The item is only released after the message has been
sent to the client" ?

> + * this is used for instance to make sure an attached data referenced

"This is used for instance to make sure attached data ..."

> + * by the marshaller is still valid when data are used */

and I would say "when it's used"

Maybe better to wait for Jonathon's input on the phrasing?

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]